Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubGrub resolver #1453

Merged
merged 1 commit into from
Jan 8, 2025
Merged

PubGrub resolver #1453

merged 1 commit into from
Jan 8, 2025

Conversation

maciektr
Copy link
Contributor

@maciektr maciektr commented Jul 17, 2024 •
edited
Loading

commit-id:d55b5ecb

This was referenced Jul 17, 2024
Closed
Closed
Merged
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch from 6ac7666 to 3c2d40c Compare July 17, 2024 13:00
@maciektr maciektr force-pushed the spr/main/3ba8d8f0 branch from 57c7fea to 5e3f300 Compare July 17, 2024 13:00
This was referenced Jul 17, 2024
Closed
Closed
@maciektr maciektr changed the title PubGrub resolver initial impl, blocking, no-graph PubGrub resolver initial implementation Oct 14, 2024
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch 2 times, most recently from 57efb17 to 7bf873b Compare October 20, 2024 18:40
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch 2 times, most recently from 121762e to c33266d Compare October 22, 2024 09:32
@maciektr maciektr changed the base branch from spr/main/3ba8d8f0 to main October 22, 2024 13:46
@maciektr maciektr changed the title PubGrub resolver initial implementation PubGrub resolver Oct 22, 2024
@maciektr maciektr mentioned this pull request Oct 22, 2024
Merged
@maciektr maciektr changed the base branch from main to spr/main/293590d9 October 22, 2024 13:46
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch 2 times, most recently from 06a2207 to 73b73d5 Compare October 26, 2024 20:38
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch 3 times, most recently from ef18fc7 to 8aba988 Compare November 4, 2024 22:52
@maciektr maciektr requested a review from mkaput November 25, 2024 14:42
@maciektr maciektr marked this pull request as ready for review November 25, 2024 14:42
@maciektr maciektr requested a review from a team as a code owner November 25, 2024 14:42
mkaput
mkaput requested changes Nov 25, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
scarb/src/resolver/algorithm/in_memory_index.rs Outdated Show resolved Hide resolved
scarb/tests/git_source.rs Outdated Show resolved Hide resolved
scarb/tests/http_registry.rs Show resolved Hide resolved
scarb/src/resolver/algorithm/mod.rs Show resolved Hide resolved
scarb/src/resolver/algorithm/state.rs Outdated Show resolved Hide resolved
wawel37
wawel37 reviewed Nov 26, 2024
View reviewed changes
scarb/src/resolver/algorithm/mod.rs Show resolved Hide resolved
scarb/src/resolver/algorithm/mod.rs Outdated Show resolved Hide resolved
@maciektr maciektr force-pushed the spr/main/d55b5ecb branch 2 times, most recently from b306a96 to b9ff78c Compare January 3, 2025 22:06
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
@maciektr
Refactor -> move simple resolver to separate mod (#1452)
0e307be 
commit-id:3ba8d8f0

---

**Stack**:
- #1453
- #1665
- #1452 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2025
@maciektr
Add once_map package (#1665)
e18c4ef 
commit-id:293590d9

---

**Stack**:
- #1453
- #1665 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/293590d9 to main January 7, 2025 22:57
@maciektr maciektr requested review from mkaput and a team January 8, 2025 11:56
@maciektr
PubGrub resolver
7ee2eeb 
commit-id:d55b5ecb
@maciektr maciektr enabled auto-merge January 8, 2025 12:52
@maciektr maciektr added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 770170a Jan 8, 2025
18 of 29 checks passed
@maciektr maciektr deleted the spr/main/d55b5ecb branch January 8, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wawel37 wawel37 wawel37 left review comments

@mkaput mkaput mkaput approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maciektr @mkaput @wawel37